-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bunch of final
keywords
#2927
Conversation
... to the classes and methods we did not intend to allow extending or overriding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
core/src/main/java9/com/linecorp/armeria/internal/common/Java9VersionSpecific.java
Outdated
Show resolved
Hide resolved
@@ -23,7 +23,7 @@ | |||
import io.netty.channel.ChannelFuture; | |||
import io.netty.channel.ChannelHandlerContext; | |||
|
|||
class Http1ServerKeepAliveHandler extends KeepAliveHandler { | |||
final class Http1ServerKeepAliveHandler extends KeepAliveHandler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! @trustin 🙇♂️
... to the classes and methods we did not intend to allow extending or overriding.
... to the classes and methods we did not intend to allow extending or
overriding.